rule-parser: fix stripping of quotes

Re-add '\' when found to not be escaping a double quote. GitHub issue: #177
jasonish · Jun 8, 2021 · 0b63979 · 0b63979
1 parent de3bdc2
commit 0b63979
Showing 1 changed file with 25 additions and 11 deletions.
diff --git a/suricata-rule-parser/src/lib.rs b/suricata-rule-parser/src/lib.rs
@@ -225,18 +225,21 @@ fn strip_quotes(input: &str) -> String {
     let mut out: Vec<char> = Vec::new();
 
     for c in input.chars() {
-        if escaped {
-            out.push(c);
-            escaped = false;
-        } else {
-            match c {
-                '"' => {}
-                '\\' => {
-                    escaped = true;
-                }
-                _ => {
-                    out.push(c);
+        match c {
+            '"' if escaped => {
+                out.push(c);
+                escaped = false;
+            }
+            '"' => {}
+            '\\' => {
+                escaped = true;
+            }
+            _ => {
+                if escaped {
+                    out.push('\\');
+                    escaped = false;
                 }
+                out.push(c);
             }
         }
     }
@@ -436,6 +439,17 @@ mod tests {
                 }
             ))
         );
+
+        assert_eq!(
+            parse_option(r#"pcre:"/^/index\.html/$/U";"#),
+            Ok((
+                "",
+                RuleOption {
+                    key: String::from("pcre"),
+                    val: Some(r#"/^/index\.html/$/U"#.to_string()),
+                }
+            ))
+        );
     }
 
     #[test]