Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced Refletions API #40

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Replaced Refletions API #40

merged 3 commits into from
Jul 19, 2022

Conversation

DenuxPlays
Copy link
Collaborator

@DenuxPlays DenuxPlays commented Jul 19, 2022 •
edited
Loading

  • replaced/removed the reflections api
  • replaced it with my own implementation
  • and upgraded JDA to 5.0.0-alpha.16

@DenuxPlays DenuxPlays added the enhancement Enhancement to an already existing feature. label Jul 19, 2022
@DenuxPlays DenuxPlays marked this pull request as ready for review July 19, 2022 20:26
@jasonlessenich
Copy link
Owner

does the api gradle thing work? We’ve tested that before but didn’t found a suitable solution

@DenuxPlays
Copy link
Collaborator Author

does the api gradle thing work? We’ve tested that before but didn’t found a suitable solution

Yeah...
You can test it yourself. Add DIH4JDA before this pr to a Project and generate the gradle dependency tree and you can see that dih4jda doesnt have a connection to the jda in your project. If you know what I mean...

@jasonlessenich
Copy link
Owner

alrighty guess it’s settled then

@jasonlessenich jasonlessenich merged commit 507f368 into jasonlessenich:v1.6 Jul 19, 2022
@jasonlessenich jasonlessenich mentioned this pull request Jul 19, 2022
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonlessenich jasonlessenich jasonlessenich approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement to an already existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DenuxPlays @jasonlessenich