Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored & Abstracted DIH4JDAEvents #60

Merged
merged 6 commits into from
Nov 10, 2022
Merged

Refactored & Abstracted DIH4JDAEvents #60

merged 6 commits into from
Nov 10, 2022

Conversation

jasonlessenich
Copy link
Owner

This PR refactors the DIH4JDA class, by abstracting the enums

@jasonlessenich jasonlessenich added the enhancement Enhancement to an already existing feature. label Nov 10, 2022
@jasonlessenich jasonlessenich self-assigned this Nov 10, 2022
@jasonlessenich jasonlessenich changed the base branch from dev to v1.6 November 10, 2022 18:48
@jasonlessenich jasonlessenich added the missing docs Documentation needed! label Nov 10, 2022
@DenuxPlays DenuxPlays added the breaking Contains a backwards incompatible change(s) label Nov 10, 2022
@DenuxPlays DenuxPlays mentioned this pull request Nov 10, 2022
Merged
19 tasks
@jasonlessenich jasonlessenich marked this pull request as ready for review November 10, 2022 19:36
@jasonlessenich
Copy link
Owner Author

bruh, thats not an annotation, brain shut off

@DenuxPlays
Copy link
Collaborator

bruh, thats not an annotation, brain shut off

Did it ever turn on?

@DenuxPlays DenuxPlays self-requested a review November 10, 2022 19:58
@MoonTM-GIT
Copy link
Collaborator

image

@DenuxPlays DenuxPlays removed the missing docs Documentation needed! label Nov 10, 2022
@jasonlessenich jasonlessenich merged commit 4dc4cb5 into v1.6 Nov 10, 2022
@jasonlessenich jasonlessenich deleted the dynxsty/refactor_events branch November 10, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenuxPlays DenuxPlays DenuxPlays approved these changes

Assignees

@jasonlessenich jasonlessenich

Labels
breaking Contains a backwards incompatible change(s) enhancement Enhancement to an already existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonlessenich @DenuxPlays @MoonTM-GIT