Integrated JDA's command-entities into SlashCommand & SlashCommand.Subcommand & made SmartQueue non-blocking
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Command.Subcommand` (to add support for dynamic slash command mentions
DenuxPlays
requested changes
Nov 11, 2022
src/main/java/xyz/dynxsty/dih4jda/interactions/commands/ExecutableCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/xyz/dynxsty/dih4jda/interactions/commands/SlashCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/xyz/dynxsty/dih4jda/interactions/commands/SlashCommand.java
Outdated
Show resolved
Hide resolved
|
Pls update pr name and/or description because you did a bit more |
19 tasks
DenuxPlays
added
enhancement
jasonlessenich
changed the title
SlashCommand & SlashCommand.SubcommandSlashCommand & SlashCommand.Subcommand & made SmartQueue non-blocking
…g map on `SlashCommand#addSubcommandGroups`
…Subcommand` for SubcommandGroups
DenuxPlays
requested changes
Nov 11, 2022
src/main/java/xyz/dynxsty/dih4jda/events/ThrowableDIH4JDAEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/xyz/dynxsty/dih4jda/interactions/commands/SlashCommand.java
Show resolved
Hide resolved
DenuxPlays
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds JDA's command-entities into
SlashCommand&SlashCommand.Subcommand, which allows the use of, for example, slash commands mentions. In addition to that, this PR also brings some QOL enhancements, like theSlashCommand.SubcommandGroupclass which replaces the rather annoyingMap<SubcommandGroupData, Subcommand[]>and brings some bug fixes regarding SmartQueue.