Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Internal Command Structure #64

Merged
merged 8 commits into from
Nov 12, 2022

Conversation

jasonlessenich
Copy link
Owner

This PR refactors the internal command structure, similar to #50, but in a more modular and expandable way.
TextCommands are not part of this PR, but are considered for a future release

DIH4JDA Internal Command Structure

@jasonlessenich jasonlessenich added enhancement Enhancement to an already existing feature. breaking Contains a backwards incompatible change(s) labels Nov 12, 2022
@jasonlessenich jasonlessenich self-assigned this Nov 12, 2022
@jasonlessenich jasonlessenich changed the base branch from dev to v1.6 November 12, 2022 11:52
Copy link
Collaborator

@DenuxPlays DenuxPlays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@jasonlessenich jasonlessenich merged commit b93989f into v1.6 Nov 12, 2022
@jasonlessenich jasonlessenich deleted the dynxsty/internal_refactor_v2 branch November 12, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Contains a backwards incompatible change(s) enhancement Enhancement to an already existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants