-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JNA wrapper for BSD <sys/extattr.h> #1549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. I left a few inline comments. Apart from these
- checkstyle found some issues, please have a look at the test results: https://github.com/java-native-access/jna/pull/1549/checks#step:6:13
- please add an entry to
CHANGES.md
for this change
contrib/platform/src/com/sun/jna/platform/bsd/extattr/ExtAttr.java
Outdated
Show resolved
Hide resolved
contrib/platform/src/com/sun/jna/platform/bsd/extattr/ExtAttrUtil.java
Outdated
Show resolved
Hide resolved
contrib/platform/src/com/sun/jna/platform/bsd/extattr/ExtAttrUtil.java
Outdated
Show resolved
Hide resolved
contrib/platform/src/com/sun/jna/platform/bsd/extattr/ExtAttrUtil.java
Outdated
Show resolved
Hide resolved
contrib/platform/src/com/sun/jna/platform/bsd/extattr/ExtAttrUtil.java
Outdated
Show resolved
Hide resolved
I've made the suggested changes. |
Thank you for the update. Would you please rebase onto master and squash this into a single commit? I'll merge then. |
GitHub still doesn't have a "merge as single commit" button just for the convenience? I'll see what I can do. |
It has, and literally everytime I used it, it broke something. github has a funny interpretation what is valid author information. The Apache NetBeans project deactivated the button as multiple time merges were done with If a local squash is a problem, please indicate, then I'll do it. |
Well, that didn't work... |
No worries. I'll just make a new clean PR. |
Sorry, I was out-gitted and broke things. New PR here: |
This is a JNA wrapper for the libc xattr functions on BSD platforms (similar to the native bindings already available for Linux and macOS in the platform jar).
The primary motivation for this contribution is
UnixUserDefinedFileAttributeView.list()
not working in the OpenJDK FreeBSD port:battleblow/jdk17u@05dca17#r125181377
NOTE:
This code is tested on production on FreeBSD, but we don't have automated test cases because the
sys/extattr.h
native functions are only available on BSD platforms, and so automated tests on Linux won't work.