Consistently use the padded element size #93
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to 3.6.2.4. Data Alignment of the specification, padding bytes have to be inserted at the end of columns of certain
MATn
types. The general difference between an "element size" and an "element size with padding" may be thatMAT2
withGL_BYTE
is 4MAT2
withGL_BYTE
is 8This was already anticipated, e.g. with the
ElementType
class. But some classes (most importantly theBufferStructureBuilder
) did not anticipate this, and did write 'wrong' data into the buffers when the inputs have been one of the affected matrix types.