Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove REQUEST_INSTALL_PACKAGES permission. #1

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

thebeast1
Copy link

I comment the function than request the REQUEST_INSTALL_PACKAGES permission because when i was trying to deploy on google paly, my app was rejected because of this permission.

@thebeast1
Copy link
Author

remove dangerous permission REQUEST_INSTALL_PACKAGES in Android in OpenFilePlugin.java

@rpekarek-tc
Copy link

We are having this issue as well, even though the permission has been removed it from the manifest. It seems as if Google is doing a plain text search. Maybe it should be deleted altogether instead of commented out?

@thebeast1
Copy link
Author

I did remove this commit in my app after they reject my release and submit another one and they still reject the app, 
Even though I did reverse engineering for the aab to make sure that this permission does not exist in the manifest file, I don't know why they still see that we use this permission.

@marcellocamara
Copy link

marcellocamara commented Oct 14, 2022

I'm facing this same problem too. I was using open_file, and changed to this one, cleaned the setup and Google Play is still recusing my app update due to this permission.

The curious detail is that I've read the entire merged_manifests, and there is no such permission. Why the hell Google Play still rejecting?

@RafaRuiz
Copy link

Same thing here, no matter open_file with

    <uses-permission android:name="android.permission.REQUEST_INSTALL_PACKAGES" tools:node="remove"/>

or open_filex

or any fork with no mention in the code about the permission, we're getting it rejected too.

@thebeast1
Copy link
Author

That's the same thing that happened to us too, and got rejected.
Then we submitted an appeal, but that process took too long,
We removed the permission even from commented code from the package (in case they are doing a plain search into reversed code).
Then "because our case was a new app" we created a new project on the play console, and it got approved within a couple of hours, and all updates after went smoothly as well.

@marcellocamara
Copy link

The appeal seems to resolve it.

In my case, I sent an appeal, and they rejected for another reason now (this is very much strange).

Your offer does not clearly and accurately describe the terms of your subscription, including the cost, frequency of billing cycle, and whether a subscription is required to use the app.

My app is with the same subscription area for more than 1 year 😄

Copy link
Owner

@javaherisaber javaherisaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thebeast1
I've been busy lately that's why I couldn't take a look at your PR
Thanks for noticing the issue and the fix

@javaherisaber javaherisaber merged commit 304691e into javaherisaber:master Oct 25, 2022
@javaherisaber
Copy link
Owner

@thebeast1 @rpekarek-tc @marcellocamara @RafaRuiz
A new version for this issue is published now at open_filex

javaherisaber pushed a commit that referenced this pull request Nov 2, 2022
ThomasTebbe referenced this pull request in 123erfasst/open_filex Nov 8, 2022
This reverts commit 304691e, reversing
changes made to 9a95e90.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants