GH-161 Check if WebJarHandler is already registered #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzikoysk
reviewed
Feb 23, 2023
...ns/javalin-swagger-plugin/src/main/kotlin/io/javalin/openapi/plugin/swagger/SwaggerPlugin.kt
Outdated
Show resolved
Hide resolved
dzikoysk
requested changes
Feb 26, 2023
...ns/javalin-swagger-plugin/src/main/kotlin/io/javalin/openapi/plugin/swagger/SwaggerPlugin.kt
Outdated
Show resolved
Hide resolved
...avalin-swagger-plugin/src/test/kotlin/io/javalin/openapi/plugin/swagger/SwaggerPluginTest.kt
Outdated
Show resolved
Hide resolved
…xist # Conflicts: # javalin-plugins/javalin-swagger-plugin/src/main/kotlin/io/javalin/openapi/plugin/swagger/SwaggerPlugin.kt # javalin-plugins/javalin-swagger-plugin/src/test/kotlin/io/javalin/openapi/plugin/swagger/SwaggerPluginTest.kt
dzikoysk
changed the title
|
Thanks! I've applied some changes we've spoked about in cr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #161 by carefully checking if such a configured
SwaggerWebJarHandleralready exists and if not, registers one perSwaggerPlugin. Includes a unit test to demonstrate and confirm the new behaviour.In the rare circumstance, that someone already would have a non
SwaggerWebJarHanlderGEThandler on the configured swagger webjar route, this implementation would -in my opinion- rightfully fail.Replaces #162 due to polluted git history.