Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow creating transitions without any approvals #116

Closed
javrasya opened this issue Nov 10, 2019 · 0 comments
Closed

Allow creating transitions without any approvals #116

javrasya opened this issue Nov 10, 2019 · 0 comments
Labels
enhancement
Milestone
3.0.0

Comments

@javrasya
Copy link
Owner

Description:

In order to have a transition in django-river, there should at least be a transition approval meta or transition approval. It is good to keep the transition information even though there is neither a transition approval meta nor transition approval

Acceptance Criteria:

  • Introduce TransitionMeta and move source_state and destination_state from TransitionApprovalMeta to here and have a relation to this new model
  • Introduce Transition and move source_state, destination_state and iteration from TransitionApproval to here and have a relation to this new model
  • Change all the places where it uses source_state,destination_state, and iteration from TransitionApproval or TransitionApprovalMeta to their new places.
javrasya added a commit that referenced this issue Nov 10, 2019
@javrasya
[#116] Allow creating transitions without any approvals and introduce…
dce7b71 
… TransitionMeta and Transition models
@javrasya javrasya added this to the 2.1.0 milestone Nov 10, 2019
javrasya added a commit that referenced this issue Nov 10, 2019
@javrasya
[#116] Allow creating transitions without any approvals and introduce…
590544c 
… TransitionMeta and Transition models
javrasya added a commit that referenced this issue Nov 11, 2019
@javrasya
[#116] Allow creating transitions without any approvals and introduce…
64e8782 
… TransitionMeta and Transition models
javrasya added a commit that referenced this issue Nov 13, 2019
@javrasya
[#116] Allow creating transitions without any approvals and introduce…
0de3802 
… TransitionMeta and Transition models
javrasya added a commit that referenced this issue Nov 16, 2019
@javrasya
[#116] Allow creating transitions without any approvals and introduce…
8bbac0b 
… TransitionMeta and Transition models
javrasya added a commit that referenced this issue Nov 17, 2019
@javrasya
[#116] Allow creating transitions without any approvals and introduce…
229b727 
… TransitionMeta and Transition models
javrasya added a commit that referenced this issue Nov 17, 2019
@javrasya
[#116] Allow creating transitions without any approvals and introduce…
ec8beb0 
… TransitionMeta and Transition models
javrasya added a commit that referenced this issue Nov 17, 2019
@javrasya
[#116] Allow creating transitions without any approvals and introduce…
8759303 
… TransitionMeta and Transition models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@javrasya