Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tutorial for data loaders on cpu with jax #108

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

selamw1
Copy link
Contributor

@selamw1 selamw1 commented Nov 21, 2024

Adding Introduction to Data Loaders on CPU with JAX.

@jakevdp
Copy link
Collaborator

jakevdp commented Nov 21, 2024

Looks good! We just need to fix the doc build errors, which are coming from the fact that the notebook has inconsistent markdown headings.

@selamw1
Copy link
Contributor Author

selamw1 commented Nov 22, 2024

Headings adjusted.

@trallard
Copy link
Contributor

@selamw1 there seem to be a couple of merge conflicts here would you be able to fix them, please?

@selamw1
Copy link
Contributor Author

selamw1 commented Nov 26, 2024

File conflict resolved.

Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the md and ipynb files are out-of-sync; you should be able to fix this locally by running

pre-commit run jupytext --all-files

@selamw1
Copy link
Contributor Author

selamw1 commented Dec 2, 2024

It looks like the md and ipynb files are out-of-sync; you should be able to fix this locally by running

pre-commit run jupytext --all-files

The md and ipynb files are paired with the above command.

@jakevdp
Copy link
Collaborator

jakevdp commented Dec 3, 2024

The notebook execution is timing out during the doc build. If you want execution to be skipped within the CI (which is probably a good idea) we need to add the notebook to the list here:

nb_execution_excludepatterns = [
'JAX_for_PyTorch_users.ipynb',
'JAX_porting_PyTorch_model.ipynb',
'digits_diffusion_model.ipynb',
'JAX_for_LLM_pretraining.ipynb',
'JAX_basic_text_classification.ipynb',
'JAX_examples_image_segmentation.ipynb',
'JAX_Vision_transformer.ipynb',
'JAX_machine_translation.ipynb',
'JAX_time_series_classification.ipynb',
]

@jakevdp
Copy link
Collaborator

jakevdp commented Dec 3, 2024

You'll need to include the new tutorial in the toctree here:

```{toctree}

Also, please resolve the conflicts. Thanks!

@jakevdp jakevdp merged commit 776df65 into jax-ml:main Dec 3, 2024
6 checks passed
windmaple pushed a commit to windmaple/jax-ai-stack that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants