-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tutorial for data loaders on cpu with jax #108
Conversation
Looks good! We just need to fix the doc build errors, which are coming from the fact that the notebook has inconsistent markdown headings. |
Headings adjusted. |
@selamw1 there seem to be a couple of merge conflicts here would you be able to fix them, please? |
File conflict resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the md
and ipynb
files are out-of-sync; you should be able to fix this locally by running
pre-commit run jupytext --all-files
The |
The notebook execution is timing out during the doc build. If you want execution to be skipped within the CI (which is probably a good idea) we need to add the notebook to the list here: Lines 83 to 93 in 47125fe
|
You'll need to include the new tutorial in the toctree here: jax-ai-stack/docs/tutorials.md Line 7 in 1998729
Also, please resolve the conflicts. Thanks! |
Adding Introduction to Data Loaders on CPU with JAX.