Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove named shapes from avals #21069

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

mattjj
Copy link
Collaborator

@mattjj mattjj commented May 4, 2024

Just an experiment, figuring out what breaks.

@mattjj mattjj added the pull ready Ready for copybara import and testing label May 4, 2024
@mattjj mattjj force-pushed the remove-named-shapes branch 3 times, most recently from 2f5ed8b to 4d744f6 Compare May 4, 2024 00:36
@mattjj mattjj force-pushed the remove-named-shapes branch 6 times, most recently from 1585f45 to a5896a1 Compare July 24, 2024 19:17
@mattjj mattjj requested a review from yashk2810 July 24, 2024 19:20
@mattjj mattjj marked this pull request as ready for review July 24, 2024 19:20
@mattjj mattjj force-pushed the remove-named-shapes branch from a5896a1 to 648a735 Compare July 24, 2024 19:23
Copy link
Collaborator

@yashk2810 yashk2810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should rebase to HEAD (pjit changes except for 1 place are not needed anymore)

@mattjj mattjj force-pushed the remove-named-shapes branch from 648a735 to ebd67cc Compare July 25, 2024 00:03
@mattjj mattjj force-pushed the remove-named-shapes branch 3 times, most recently from 92e5c59 to 5f85c77 Compare July 25, 2024 00:47
@mattjj mattjj force-pushed the remove-named-shapes branch from 5f85c77 to 3f9eb40 Compare July 25, 2024 00:55
@copybara-service copybara-service bot merged commit 086b500 into jax-ml:main Jul 25, 2024
11 of 14 checks passed
@mattjj mattjj deleted the remove-named-shapes branch July 25, 2024 02:20
@mattjj mattjj self-assigned this Jul 25, 2024
@sharadmv
Copy link
Collaborator

Goodbye old friend 🫡

copybara-service bot pushed a commit to google-research/t5x that referenced this pull request Jul 25, 2024
…skaya et al

fixes breakage from cl/655766534 aka jax-ml/jax#21069

PiperOrigin-RevId: 655783604
copybara-service bot pushed a commit that referenced this pull request Jul 25, 2024
…skaya et al

fixes breakage from cl/655766534 aka #21069

PiperOrigin-RevId: 655783604
copybara-service bot pushed a commit to google-research/t5x that referenced this pull request Jul 25, 2024
…skaya et al

fixes breakage from cl/655766534 aka jax-ml/jax#21069

PiperOrigin-RevId: 655783604
copybara-service bot pushed a commit that referenced this pull request Jul 25, 2024
…skaya et al

fixes breakage from cl/655766534 aka #21069

PiperOrigin-RevId: 655783604
copybara-service bot pushed a commit to google-research/t5x that referenced this pull request Jul 25, 2024
…skaya et al

fixes breakage from cl/655766534 aka jax-ml/jax#21069

PiperOrigin-RevId: 655783604
copybara-service bot pushed a commit that referenced this pull request Jul 25, 2024
…skaya et al

fixes breakage from cl/655766534 aka #21069

PiperOrigin-RevId: 655783604
copybara-service bot pushed a commit to google-research/t5x that referenced this pull request Jul 25, 2024
…skaya et al

fixes breakage from cl/655766534 aka jax-ml/jax#21069

PiperOrigin-RevId: 655783604
copybara-service bot pushed a commit that referenced this pull request Jul 25, 2024
…skaya et al

fixes breakage from cl/655766534 aka #21069

PiperOrigin-RevId: 655783604
copybara-service bot pushed a commit to google-research/t5x that referenced this pull request Jul 25, 2024
…skaya et al

fixes breakage from cl/655766534 aka jax-ml/jax#21069

PiperOrigin-RevId: 655783604
copybara-service bot pushed a commit to google-research/t5x that referenced this pull request Jul 25, 2024
…skaya et al

fixes breakage from cl/655766534 aka jax-ml/jax#21069

PiperOrigin-RevId: 655783604
copybara-service bot pushed a commit that referenced this pull request Jul 25, 2024
…skaya et al

fixes breakage from cl/655766534 aka #21069

PiperOrigin-RevId: 655783604
copybara-service bot pushed a commit to google-research/t5x that referenced this pull request Jul 25, 2024
…skaya et al

fixes breakage from cl/655766534 aka jax-ml/jax#21069

PiperOrigin-RevId: 655806010
copybara-service bot pushed a commit that referenced this pull request Jul 25, 2024
…skaya et al

fixes breakage from cl/655766534 aka #21069

PiperOrigin-RevId: 655806010
nitins17 pushed a commit to google-ml-infra/jax-fork that referenced this pull request Aug 27, 2024
…skaya et al

fixes breakage from cl/655766534 aka jax-ml#21069

PiperOrigin-RevId: 655806010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull ready Ready for copybara import and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants