-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove named shapes from avals #21069
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjj
force-pushed
the
remove-named-shapes
branch
3 times, most recently
from
May 4, 2024 00:36
2f5ed8b
to
4d744f6
Compare
mattjj
force-pushed
the
remove-named-shapes
branch
6 times, most recently
from
July 24, 2024 19:17
1585f45
to
a5896a1
Compare
mattjj
force-pushed
the
remove-named-shapes
branch
from
July 24, 2024 19:23
a5896a1
to
648a735
Compare
yashk2810
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should rebase to HEAD (pjit changes except for 1 place are not needed anymore)
mattjj
force-pushed
the
remove-named-shapes
branch
from
July 25, 2024 00:03
648a735
to
ebd67cc
Compare
mattjj
force-pushed
the
remove-named-shapes
branch
3 times, most recently
from
July 25, 2024 00:47
92e5c59
to
5f85c77
Compare
mattjj
force-pushed
the
remove-named-shapes
branch
from
July 25, 2024 00:55
5f85c77
to
3f9eb40
Compare
Goodbye old friend 🫡 |
copybara-service bot
pushed a commit
to google-research/t5x
that referenced
this pull request
Jul 25, 2024
…skaya et al fixes breakage from cl/655766534 aka jax-ml/jax#21069 PiperOrigin-RevId: 655783604
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
…skaya et al fixes breakage from cl/655766534 aka #21069 PiperOrigin-RevId: 655783604
copybara-service bot
pushed a commit
to google-research/t5x
that referenced
this pull request
Jul 25, 2024
…skaya et al fixes breakage from cl/655766534 aka jax-ml/jax#21069 PiperOrigin-RevId: 655783604
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
…skaya et al fixes breakage from cl/655766534 aka #21069 PiperOrigin-RevId: 655783604
copybara-service bot
pushed a commit
to google-research/t5x
that referenced
this pull request
Jul 25, 2024
…skaya et al fixes breakage from cl/655766534 aka jax-ml/jax#21069 PiperOrigin-RevId: 655783604
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
…skaya et al fixes breakage from cl/655766534 aka #21069 PiperOrigin-RevId: 655783604
copybara-service bot
pushed a commit
to google-research/t5x
that referenced
this pull request
Jul 25, 2024
…skaya et al fixes breakage from cl/655766534 aka jax-ml/jax#21069 PiperOrigin-RevId: 655783604
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
…skaya et al fixes breakage from cl/655766534 aka #21069 PiperOrigin-RevId: 655783604
copybara-service bot
pushed a commit
to google-research/t5x
that referenced
this pull request
Jul 25, 2024
…skaya et al fixes breakage from cl/655766534 aka jax-ml/jax#21069 PiperOrigin-RevId: 655783604
copybara-service bot
pushed a commit
to google-research/t5x
that referenced
this pull request
Jul 25, 2024
…skaya et al fixes breakage from cl/655766534 aka jax-ml/jax#21069 PiperOrigin-RevId: 655783604
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
…skaya et al fixes breakage from cl/655766534 aka #21069 PiperOrigin-RevId: 655783604
copybara-service bot
pushed a commit
to google-research/t5x
that referenced
this pull request
Jul 25, 2024
…skaya et al fixes breakage from cl/655766534 aka jax-ml/jax#21069 PiperOrigin-RevId: 655806010
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
…skaya et al fixes breakage from cl/655766534 aka #21069 PiperOrigin-RevId: 655806010
nitins17
pushed a commit
to google-ml-infra/jax-fork
that referenced
this pull request
Aug 27, 2024
…skaya et al fixes breakage from cl/655766534 aka jax-ml#21069 PiperOrigin-RevId: 655806010
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an experiment, figuring out what breaks.