Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.6 support. #7294

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Drop Python 3.6 support. #7294

merged 1 commit into from
Jul 15, 2021

Conversation

hawkinsp
Copy link
Collaborator

Per the deprecation policy (https://jax.readthedocs.io/en/latest/deprecation.html), Python 3.6 support has been due for removal since June 23, 2020.

@hawkinsp hawkinsp requested a review from skye July 15, 2021 13:54
@hawkinsp hawkinsp self-assigned this Jul 15, 2021
@google-cla google-cla bot added the cla: yes label Jul 15, 2021
skye
skye approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@skye skye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the check failures are due to the presubmit changes? Overall LGTM once the checks pass.

@hawkinsp
Drop Python 3.6 support.
94446ff 
Per the deprecation policy (https://jax.readthedocs.io/en/latest/deprecation.html),
Python 3.6 support has been due for removal since June 23, 2020.
@hawkinsp
Copy link
Collaborator Author

Not sure if the check failures are due to the presubmit changes? Overall LGTM once the checks pass.

Fixed.

@hawkinsp hawkinsp added the pull ready Ready for copybara import and testing label Jul 15, 2021
@copybara-service copybara-service bot merged commit 6aa20d8 into jax-ml:main Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skye skye skye approved these changes

Assignees

@hawkinsp hawkinsp

Labels
cla: yes pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hawkinsp @skye