Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Completion when No Network is Available #133

Open
jalcine opened this issue Jan 12, 2015 · 1 comment
Open

Disable Completion when No Network is Available #133

jalcine opened this issue Jan 12, 2015 · 1 comment

Comments

@jalcine
Copy link
Contributor

jalcine commented Jan 12, 2015

This plugin is notorious for hanging up my committing sessions when I'm disconnected from a network. It throws an exception (uncaught somewhere in the stack) and causes Vim to assume that the file (.git/COMMIT_MSG) was already saved.

This is me eyeballing community interest as I'm working on a patch to catch this example. All in all, if it can't connect or find the repository in question, it should fail silently (or at least provide an option to fail silently).

@jaxbot
Copy link
Owner

jaxbot commented Jan 12, 2015

I agree with this; often times my Vim lags because of net issues and autocomplete trying to populate. I added some timeout stuff a while ago but it didn't really help.

The async/threading feature will help, but it's not the most optimal feature.

I can make it fail silently, but I think the biggest problem is the lag. If you have a patch that makes it better in your case, though, please feel free to PR!

jaxbot added a commit that referenced this issue Jan 14, 2015
Update #133 Disable Completion when No Network is Available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants