Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-issues may cause extreme slowdown in vim #140

Open
JonathanReeve opened this issue Apr 9, 2015 · 6 comments
Open

github-issues may cause extreme slowdown in vim #140

JonathanReeve opened this issue Apr 9, 2015 · 6 comments

Comments

@JonathanReeve
Copy link

I noticed that when I ran git commit, there would be a 30- to 40-second pause while vim loads. I did some profiling and found that this was caused by the function <SNR>24_setupOmni(). A little grepping found this in github-issues.vim, and when I disabled github-issues, vim started up instantly. So I think there may be something with github-issues that causes vim to slow down considerably. Maybe I have lots and lots of issues in all my repositories, and so it takes a while to load all of these? I'm not sure what it could be. But I'm happy to run some debugging commands on my setup if it will help debug this issue.

@TheJefe
Copy link
Contributor

TheJefe commented Apr 16, 2015

Does this happen on a public repo? If so, let us know, and we can probably use that to reproduce this, if it has something to do with that particular repo.

@jaxbot
Copy link
Owner

jaxbot commented Apr 16, 2015

I can reproduce this. It's an issue with network. The plugin is supposed to
timeout automatically but sometimes that doesn't seem to work. I'll dig
into it after this week. Finals and stuff :/

On Wed, Apr 15, 2015, 10:17 PM Jeff Koenig [email protected] wrote:

Does this happen on a public repo? If so, let us know, and we can probably
use that to reproduce this, if it has something to do with that particular
repo.


Reply to this email directly or view it on GitHub
#140 (comment)
.

@JonathanReeve
Copy link
Author

That was happening on the public repo mlaa/digitalpedagogy. I thought it could be repo-related, since that particular repo has a bunch of images (and I know git isn't great with binaries), but I was seeing that issue on other repos, as well.

@jaxbot
Copy link
Owner

jaxbot commented Apr 19, 2015

Problem is basically that there are a ton of urllib open calls in the plugin, and 90% of them have no timeouts. Since this all runs on a single thread, it causes Vim to freeze. I've played with threading before but had some ugly results, honestly there just needs to be a standardized way in the plugin to make an HTTP call in async.

@JonathanReeve JonathanReeve changed the title github-issues may extreme slowdown in vim github-issues may cause extreme slowdown in vim Apr 20, 2015
jaxbot added a commit that referenced this issue May 7, 2015
Solves an issue where gissues_async_omni is set but the network is down.

Updates #140
@wikimatze
Copy link
Contributor

Hi @jaxbot I tried g:gissues_async_omni = 0 and let g:gissues_lazy_load = 1 and it is still slow when doint a :Gcommit - any other things is working great for creating a new issue or to look up issues. How many urlib librtaries have you tried out? Is there a way to help you out?

@jaxbot
Copy link
Owner

jaxbot commented Aug 26, 2015

It seriously needs some fixing down at the core. I started some work on this over the summer but got sidetracked with other projects. If you want to dive into it, feel free, otherwise I'll get it fixed sometime in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants