-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github-issues may cause extreme slowdown in vim #140
Comments
Does this happen on a public repo? If so, let us know, and we can probably use that to reproduce this, if it has something to do with that particular repo. |
I can reproduce this. It's an issue with network. The plugin is supposed to On Wed, Apr 15, 2015, 10:17 PM Jeff Koenig [email protected] wrote:
|
That was happening on the public repo mlaa/digitalpedagogy. I thought it could be repo-related, since that particular repo has a bunch of images (and I know git isn't great with binaries), but I was seeing that issue on other repos, as well. |
Problem is basically that there are a ton of urllib open calls in the plugin, and 90% of them have no timeouts. Since this all runs on a single thread, it causes Vim to freeze. I've played with threading before but had some ugly results, honestly there just needs to be a standardized way in the plugin to make an HTTP call in async. |
Solves an issue where gissues_async_omni is set but the network is down. Updates #140
Hi @jaxbot I tried |
It seriously needs some fixing down at the core. I started some work on this over the summer but got sidetracked with other projects. If you want to dive into it, feel free, otherwise I'll get it fixed sometime in the future |
I noticed that when I ran
git commit
, there would be a 30- to 40-second pause while vim loads. I did some profiling and found that this was caused by the function<SNR>24_setupOmni()
. A little grepping found this in github-issues.vim, and when I disabled github-issues, vim started up instantly. So I think there may be something with github-issues that causes vim to slow down considerably. Maybe I have lots and lots of issues in all my repositories, and so it takes a while to load all of these? I'm not sure what it could be. But I'm happy to run some debugging commands on my setup if it will help debug this issue.The text was updated successfully, but these errors were encountered: