cgroups2/Stats: split out reading cpu, memory, memory events #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
commented
Feb 11, 2025
cgroup2/manager.go
Outdated
| return &metrics, nil | ||
| } | ||
|
|
||
| func readMemoryEvents(cgroupPath string) (*stats.MemoryEvents, error) { |
There was a problem hiding this comment.
Alternatively, this could be a method (instead of passing the path as argument);
Suggested change
| func readMemoryEvents(cgroupPath string) (*stats.MemoryEvents, error) { | |
| func (c *Manager) readMemoryEvents() (*stats.MemoryEvents, error) { |
My consideration was that having it as a plain function could be easier to add unit tests for, but of course we could probably construct a Manager{path: "some custom path"}, so probably either way would work
As outlined in the PR, usage_usec, user_usec, and system_use may always exist, but in situations where the files parsed do not exist, we shouldn't have to try to assign values (which would always be 0). Split out parsing of these to separate functions, so make this more transparent. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
348_suggestions
branch
from
e309de2 to
58f4859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in the PR, usage_usec, user_usec, and system_use may always exist, but in situations where the files parsed do not exist, we shouldn't have to try to assign values (which would always be 0).
Split out parsing of these to separate functions, so make this more transparent.