create the neotree window by display-buffer-in-side-window.
#197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`display-buffer-in-side-window` prevent the awkward situation that neotree becomes the only window in the emacs and no split can work. Besides, previous attempts using `defadvice` on `delete-window` and `delete-other-window` is hard to reason.
After we switch to `display-side-window`, we do not need this option anymore. neotree window will never be lonely from now on. I believe this is more intuitive than leaving a tree-view solely in an editor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
display-buffer-in-side-windowprevent the awkward situation that neotree becomes the only window in the emacs and no split can work. Besides, previous attempts usingdefadviceondelete-windowanddelete-other-windowis hard to reason.You can test this by using 'C-x 0' on the main window by using the following startup script to check if the awkward moment comes.