Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes command key on Firefox MacOSx #109

Merged
merged 2 commits into from
Sep 17, 2019

Conversation

lbittner-pdftron
Copy link
Contributor

In main.js@dispatch we are normalizing the command key to be 91 instead of FF's native 224:

if (key === 93 || key === 224) key = 91;
...

This contradicts the code in var.js that sets the command key as 224 if it's FF. We don't need this code as we are already normalizing it in the dispatch function.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 187

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 81.406%

Totals Coverage Status
Change from base Build 186: 0.9%
Covered Lines: 193
Relevant Lines: 207

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Sep 16, 2019

Codecov Report

Merging #109 into master will increase coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   92.89%   93.23%   +0.34%     
==========================================
  Files           1        1              
  Lines         211      207       -4     
==========================================
- Hits          196      193       -3     
+ Misses         15       14       -1
Impacted Files Coverage Δ
dist/hotkeys.js 93.23% <100%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d416f1...eeb08bc. Read the comment docs.

@jaywcjlove jaywcjlove merged commit f3cc7a2 into jaywcjlove:master Sep 17, 2019
@jaywcjlove
Copy link
Owner

@lbittner-pdftron thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants