fix ignored falsy values

when getting with multiple keys
jaywcjlove · Dec 14, 2020 · ebf0b62 · ebf0b62
1 parent b25c6e0
commit ebf0b62
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/lib/main.js b/lib/main.js
@@ -65,7 +65,7 @@ Store.prototype = {
       const dt = {};
       for (var i = 0, len = args.length; i < len; i++) {
         const value = deserialize(storage.getItem(args[i]));
-        if (value) {
+        if (this.has(args[i])) {
           dt[args[i]] = value;
         }
       }

diff --git a/test/store.test.js b/test/store.test.js
@@ -78,13 +78,31 @@ test('Test localstorage forEach', () => {
 });
 
 test('Get localstorage', () => {
+  store.set('namef', false);
+  store.set('namenull', null);
   expect(store('name4')).toEqual('value4');
+  expect(store.get('namef')).toEqual(false);
   expect(store.get('name4')).toEqual('value4');
-  expect(store.get()).toEqual({ 'name4': 'value4', 'name5': 'value5' });
-  expect(store.get('name4', 'nameeee')).toEqual({ "name4": 'value4' });
+  expect(store.get()).toEqual({
+    'name4': 'value4',
+    'name5': 'value5',
+    'namef': false,
+    'namenull': null,
+    'nameundefined': undefined
+  });
+  expect(store.get('name4', 'nameeee', 'namef', 'namenull', 'nameundefined')).toEqual({
+    "name4": 'value4',
+    'namef': false,
+    'namenull': null,
+    'nameundefined': undefined
+  });
   expect(store.get('name4', 'name5')).toEqual({ "name4": 'value4', "name5": "value5" });
   expect(store.get('nameeee11', 'nameeee222')).toEqual({});
   expect(store.get('name4322323')).toBeUndefined();
+
+  store.remove('namef');
+  store.remove('namenull');
+  store.remove('nameundefined');
 });
 
 test('Get all localstorage', () => {