Support for react native functional components #217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello maintainers.
Why this PR :
Ive many SVG's in a directory, in React Native, assets are loaded at buildTime.
So you must load all of them at the startup to be able to import them and add a babel transformer to make them as RN components.
The real issue with that is that it's not possible to do dynamic imports.
So a font is the main solution.
I did everything to not being dependent of an external React Native package.
Ive tested this implementation on my own project with success.
It was a little bit challenging because of those particularities:
So here is a (among unknown others) implementation of your package for ReactNative.
I would love to see this merged after all your reviews.
Im sure that it'll help many ppl.
Feel free to give me your feedback.