Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React native fixes #218

Merged
merged 1 commit into from
Dec 26, 2023
Merged

React native fixes #218

merged 1 commit into from
Dec 26, 2023

Conversation

LucasBourgeois
Copy link
Contributor

@LucasBourgeois LucasBourgeois commented Dec 26, 2023 •
edited
Loading

Here are some corrections following my ReactNative support.

  • icons are now in camelCase and no longer in PascalCase. It makes more sense to me as the generated types and map object keys and values are no components neither classes and are closed to the svg file names.
  • It generate a .jsx instead a .js

@jaywcjlove jaywcjlove merged commit e83b623 into jaywcjlove:master Dec 26, 2023
github-actions bot pushed a commit that referenced this pull request Dec 26, 2023
@jaywcjlove
v4.1.0 fix: change icon names from PascalCase to camelCase and clarif…
bdb9bf7 
…y generated types (#218)

Co-authored-by: Lucas Bourgeois <[email protected]> e83b623
@jaywcjlove
Copy link
Owner

@LucasBourgeois Upgrade v4.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucasBourgeois @jaywcjlove