-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make log entries read-only in the admin #449
Conversation
5ca8614
to
25dbda2
Compare
Thanks @alieh-rymasheuski for this. two things:
|
I think it's a bugfix. This is audit log, it shouldn't be possible to alter it with a simple button in the admin. |
@alieh-rymasheuski Do you have a plant to fix the failing test? |
25dbda2
to
0fe35d7
Compare
0fe35d7
to
de5638c
Compare
@hramezani, done. :) |
I'm afraid with that, we can't delete any record from django admin. 😬😄 |
@madomdy, do you mean that this change causes django admin to disallow deleting auditlogged objects? I am confident that some objects still can be deleted - in fact, I removed one this morning. 😄 Could you please elaborate on your issue? I'm happy to help and fix the bug that I may have introduced. |
This is a follow-up fix after a real-world staff user deleted a few auditlog entries through the admin by mistake.