-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LogEntry.changes_dict() to return {} when json.loads() returns None #472
Fix LogEntry.changes_dict() to return {} when json.loads() returns None #472
Conversation
Thanks @tykling for reporting the issue and preparing the fix. Please consider to:
|
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
=======================================
Coverage 92.74% 92.74%
=======================================
Files 26 26
Lines 786 786
=======================================
Hits 729 729
Misses 57 57
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
done |
Co-authored-by: Hasan Ramezani <[email protected]>
@tykling Thanks for the update. Please add a regression test. I mean you need to add a test that fails without your fix to show what problem you are fixing. |
I did and it does |
Ah Sorry. You are right! Thanks @tykling 👍 |
…ne (jazzband#472) Co-authored-by: Hasan Ramezani <[email protected]>
LogEntry.changes_str
raises an exception when viewing the new "accessed" AuditLog objects with no changes. This PR fixesLogEntry.changes_dict()
so it always returns a dict, even ifjson.loads()
returnsNone
.This PR fixes #471 which has the backtrace and more details 👍