Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using changes_dict in admin list #479

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Using changes_dict in admin list #479

merged 2 commits into from
Dec 16, 2022

Conversation

rptmat57
Copy link
Contributor

Using changes_dict to fix potential TypeError when changes are None in admin
Fixes #477

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #479 (7c20c66) into master (703e3e4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   92.78%   92.77%   -0.01%     
==========================================
  Files          26       26              
  Lines         790      789       -1     
==========================================
- Hits          733      732       -1     
  Misses         57       57              
Impacted Files Coverage Δ
auditlog/mixins.py 87.87% <100.00%> (-0.13%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hramezani hramezani merged commit 971a4f4 into jazzband:master Dec 16, 2022
@hramezani
Copy link
Member

Thanks @rptmat57 👍

@rptmat57
Copy link
Contributor Author

rptmat57 commented Feb 3, 2023

I noticed even though this accepted and closed a month and a half ago, it wasn't included in the latest release.
In fact the last release only had a small bug fix. Is that because of the upcoming major 3.0.0 release?

@hramezani
Copy link
Member

@rptmat57 Yes exactly. we are preparing v3 which is a major release

@rptmat57
Copy link
Contributor Author

rptmat57 commented Feb 3, 2023

ok thanks for responding so quickly! appreciate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError object of type 'NoneType' has no len() when changes are empty
2 participants