Fix unnecessary log when adding already existed m2m record #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
+ Coverage 94.23% 94.34% +0.11%
==========================================
Files 30 30
Lines 902 902
==========================================
+ Hits 850 851 +1
+ Misses 52 51 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hramezani
approved these changes
Jun 21, 2023
|
Thanks @firtk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In log_m2m_changes we are checking the queryset emptiness with
is not Nonehowever this will always evaluate to True. So when we are adding same related m2m object there will be an unnecessary log with empty objects. This PR aim is to fix that so we don't get unnecessary logs.