Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request object missing from Django authentication #636

Closed
ripal-pm opened this issue Aug 17, 2018 · 1 comment · Fixed by #949
Closed

Request object missing from Django authentication #636

ripal-pm opened this issue Aug 17, 2018 · 1 comment · Fixed by #949

Comments

@ripal-pm
Copy link

Hi,

First of all, thanks for creating this toolkit and hope this request will expand it's usage.

Many third party AUTHENTICATION_BACKENDS requires request object. This toolkit is not passing request object to django.contrib.auth.authenticate(). If you will update oauth2_validators.py=>validate_user's authenticate call from authenticate(username=username, password=password) to authenticate(request=request, username=username, password=password) will fix this issue.

Hope you will be able to make this change quickly.

Thanks with best regards,
ripal-pm
IvanAnishchuk pushed a commit that referenced this issue Oct 20, 2019
@W0126 @IvanAnishchuk
Fix issue #636, pass request object to authenticate function. (#643)
d5e6645
@adamchainz
Copy link
Contributor

Fixed in #643 I believe.

n2ygk added a commit that referenced this issue Mar 14, 2020
@n2ygk
Revert "Fix issue #636, pass request object to authenticate function. (…
4f3a296 
…#643)"

This reverts commit d5e6645.
auvipy pushed a commit that referenced this issue Mar 16, 2020
@n2ygk
Revert "Fix issue #636, pass request object to authenticate function. (…
bca1f91 
…#643)"

This reverts commit d5e6645.
@ShaheedHaque ShaheedHaque mentioned this issue Mar 20, 2021
Closed
ShaheedHaque added a commit to ShaheedHaque/django-oauth-toolkit that referenced this issue Mar 22, 2021
@ShaheedHaque
Provide django.contrib.auth.authenticate() with a request for
81fe788 
compatibiity with more backends. Resolves jazzband#712. Resolves jazzband#636.
Resolves jazzband#808.
@ShaheedHaque ShaheedHaque mentioned this issue Mar 22, 2021
Merged
5 tasks
ShaheedHaque added a commit to ShaheedHaque/django-oauth-toolkit that referenced this issue Mar 22, 2021
@ShaheedHaque
Provide django.contrib.auth.authenticate() with a request for
1bcfd5e 
compatibiity with more backends. Resolves jazzband#712. Resolves jazzband#636.
Resolves jazzband#808.
ShaheedHaque added a commit to ShaheedHaque/django-oauth-toolkit that referenced this issue Mar 22, 2021
@ShaheedHaque
Provide django.contrib.auth.authenticate() with a request for
b12a0f7 
compatibiity with more backends. Resolves jazzband#712. Resolves jazzband#636.
Resolves jazzband#808.
n2ygk added a commit that referenced this issue Mar 22, 2021
@ShaheedHaque @n2ygk
Provide django.contrib.auth.authenticate() with a request for compati…
9d2aac2 
…biity with more backends. (#949)

* Provide django.contrib.auth.authenticate() with a request for
compatibiity with more backends. Resolves #712. Resolves #636.
Resolves #808.

Co-authored-by: Alan Crosswell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@adamchainz @ripal-pm