avoid the use of pkg_resources when importlib.metadata is available #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #799 +/- ##
==========================================
- Coverage 83.19% 82.35% -0.85%
==========================================
Files 33 33
Lines 1119 1139 +20
==========================================
+ Hits 931 938 +7
- Misses 188 201 +13 ☔ View full report in Codecov by Sentry. |
|
@d9pouces |
|
It still has conflict and can't be merged, please rebase your branch with the current master branch |
|
Conflicts seem to have disappeared and this branch can be merged. |
…kg_resources is removed from Python 3.12
…kg_resources is removed from Python 3.12
for more information, see https://pre-commit.ci
peymanslh
force-pushed
the
remove_pkg_resources
branch
from
d9cd87c to
d3a7144
Compare
for more information, see https://pre-commit.ci
peymanslh
approved these changes
Dec 13, 2023
|
Thanks @d9pouces |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_resources is removed from Python 3.12, and its use raises a warning.
importlib.metadata can be used to get distribution info.