Fix bug when using gcm serializer as a nested serializer. #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamaalscarlett
force-pushed
the
fix_gcm_rest_validation
branch
from
038d7f9 to
c86a2b2
Compare
|
gtm but please fix the issue ref from |
When the serializer is nested the unique validator on registration_id does not behave correctly. This is a known issue with DRF see: encode/django-rest-framework#2403 Added missing allow_null to device_id field Fixes jazzband#270
jamaalscarlett
force-pushed
the
fix_gcm_rest_validation
branch
from
c86a2b2 to
d16c797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the serializer is nested the unique validator on registration_id
does not behave correctly. This is a known issue with DRF
see: encode/django-rest-framework#2403
Added missing allow_null to device_id field
Fixes #270