Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Silk Great Again and Upgrade Dev Project #122

Merged
merged 13 commits into from
Jul 8, 2016

Conversation

hanleyhansen
Copy link
Member

@hanleyhansen hanleyhansen commented Jul 8, 2016

What

This PR is an attempt at upgrading the included project with silk to make local development work and easier for contributors. It also fixes an issue with the usage of the django render function

  • Add default migrations for example_app
  • Use new templates structure for new Django
  • Get template discovery to work
  • Add development instructions to readme
  • Fix usages of render in silk and project
  • Fix six import. Oversight from this commit: 48b7416
  • .util seems to have disappeared from the face of the earth so need to rework anything that was using it
    • bring back delete_all_models()
    • bring back mock_data_collector()

Why

If we make it easier for devs to contribute to this project it'll be easier to help it move along.

Related: #121

@hanleyhansen hanleyhansen changed the title Upgrade Dev Project Make Silk Great Again and Upgrade Dev Project Jul 8, 2016
@avelis avelis merged commit 9118975 into jazzband:master Jul 8, 2016
@avelis
Copy link
Collaborator

avelis commented Jul 8, 2016

@hanleyhansen I appreciate your contribution to this project. Anything to alleviate contributor learning curves is greatly appreciated.

@hanleyhansen
Copy link
Member Author

@avelis thanks for the merge! i started out with a feature i wanted to add and ran into this and figured i'd put it in a better state first. New feature pr coming soon!

@hanleyhansen hanleyhansen deleted the upgrade-dev-project branch July 8, 2016 15:48
@avelis
Copy link
Collaborator

avelis commented Jul 8, 2016

@hanleyhansen I look forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants