-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Silk Great Again and Upgrade Dev Project #122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanleyhansen
changed the title
Upgrade Dev Project
Make Silk Great Again and Upgrade Dev Project
Jul 8, 2016
….util no longer exists" This reverts commit 5a527df.
@hanleyhansen I appreciate your contribution to this project. Anything to alleviate contributor learning curves is greatly appreciated. |
@avelis thanks for the merge! i started out with a feature i wanted to add and ran into this and figured i'd put it in a better state first. New feature pr coming soon! |
@hanleyhansen I look forward to it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR is an attempt at upgrading the included
project
withsilk
to make local development work and easier for contributors. It also fixes an issue with the usage of the djangorender
functionexample_app
render
insilk
andproject
.util
seems to have disappeared from the face of the earth so need to rework anything that was using itdelete_all_models()
mock_data_collector()
Why
If we make it easier for devs to contribute to this project it'll be easier to help it move along.
Related: #121