Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give users the ability to export .prof binary files for every request #123

Merged
merged 7 commits into from
Jul 8, 2016

Conversation

hanleyhansen
Copy link
Member

@hanleyhansen hanleyhansen commented Jul 8, 2016

What

Give the user the option the generate the binary .prof data and expose it via a download button in the profiling page. This functionality is driven by a new setting called SILKY_PYTHON_PROFILER_BINARY. Docs have been updated to reflect it's usage.

The download button will appear on the right only if there is an associated .prof file with the request

screen shot 2016-07-08 at 11 54 01 am

## Why

silk produces beautiful human readable output on it's profiling page via pstats but there was no way to extract this data to use in other programs like snakeviz. This PR enables the user to extract said binary data.

@hanleyhansen hanleyhansen changed the title Get users the ability to export .prof binary files for every request Give users the ability to export .prof binary files for every request Jul 8, 2016
@avelis
Copy link
Collaborator

avelis commented Jul 8, 2016

@hanleyhansen Since you added a field to the Request model, is it possible for you to add the migration file for that model change.

@hanleyhansen
Copy link
Member Author

@avelis already did 😄

see silk/migrations/0003_request_prof_file.py

@avelis avelis merged commit a4008be into jazzband:master Jul 8, 2016
@avelis
Copy link
Collaborator

avelis commented Jul 8, 2016

@hanleyhansen Thank you for this feature and general contribution to this repo.

@hanleyhansen hanleyhansen deleted the expose-binary-prof-data branch July 8, 2016 19:24
@hanleyhansen hanleyhansen mentioned this pull request Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants