Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use any readme #128

Merged
merged 1 commit into from
Jul 13, 2016
Merged

use any readme #128

merged 1 commit into from
Jul 13, 2016

Conversation

SzySteve
Copy link
Contributor

What:

  • Include any readme file

Why:

@avelis
Copy link
Collaborator

avelis commented Jul 13, 2016

@hanleyhansen @SzySteve That was exactly what I was going to do. 👍

@hanleyhansen
Copy link
Member

hanleyhansen commented Jul 13, 2016

@avelis do you mind if we simplify and just keep the md? then we wouldn't need pypandoc. Or would you prefer this approach?

@avelis
Copy link
Collaborator

avelis commented Jul 13, 2016

@hanleyhansen Correct me if I am wrong but Pypi only accepts rst based descriptions when publishing releases. This is the main reason I have the conversion logic in there.

@avelis avelis merged commit ba623c1 into jazzband:master Jul 13, 2016
This was referenced Jul 13, 2016
@hanleyhansen
Copy link
Member

@avelis you are correct. makes sense now. so only the machine uploading to pypi needs the pypandoc dependency. so this should work.

@avelis
Copy link
Collaborator

avelis commented Jul 13, 2016

@hanleyhansen I will work on a maintenance release with the manifest change shortly.

I appreciate the PR to fix this install issue.

@hanleyhansen
Copy link
Member

@avelis awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants