Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text-align property to pyprofile class for readability #176

Merged
merged 1 commit into from
May 9, 2017

Conversation

jeffreyckchau
Copy link
Contributor

Hi,

This PR adds the text-align: left to the pyprofile class in the profiling view.

image

As shown in the above screenshot, without a text align the output is difficult to read with longer function names.

image

With the text-align added, it is much more readable.

Thank you for the consideration! This is an incredibly useful package for us.

@jeffreyckchau
Copy link
Contributor Author

I'm having trouble interpreting the errors with the build here...

For django==1.9.0 && python==3.5, silk cannot be installed correctly? How does that result from a static file change?

@avelis avelis merged commit 370d9f3 into jazzband:master May 9, 2017
@avelis
Copy link
Collaborator

avelis commented May 9, 2017

@jeffreyckchau Thanks for the contribution. That will greatly increase the readability of that view. Much appreciated.

As for the failing build. There is a one test on one environment configuration that is failing. I have not gotten around to fixing it, but I don't let that impede contributions for the time being.

@jeffreyckchau jeffreyckchau deleted the profile_text_align branch May 9, 2017 21:17
@jeffreyckchau
Copy link
Contributor Author

@avelis Ah, got it. Glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants