Visualize profile result #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to quickly see the slow path through the profiled code
…ile and added some tests to verify dot generation
Fixed bug under python 2. StringIO is not a context manager
…sing the build to fail on python 3.4 while downloading pytz
|
@danielbradburn Awesome contribution! When possible, could you add image you attached in the PR to the README.md file? |
|
@avelis Ah, yes sorry I forgot about that. It's probably worth adding a note about the filtering and sorting changes I made to. Will make a separate PR with an updated README. |
danielbradburn
added a commit
to crunchr/silk
that referenced
this pull request
Dec 8, 2017
* started working on showing a graph of the profile output which helps to quickly see the slow path through the profiled code * further work on profile graph visualization * finished backend and frontend work for displaying a graph of the profile and added some tests to verify dot generation * updated requirements for graph rendering * Fixed error in python 2 due to no mock library * update travis file to also install test requirements * removed double reference to mock in test-requirements * Fixed broken version number * Update profile_dot.py Fixed bug under python 2. StringIO is not a context manager * Open temp file in binary mode * fixed failing test on python 2 due to string encoding * added travis_retry to pip install steps since the pip install was causing the build to fail on python 3.4 while downloading pytz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a visualization of the cprofile result as a graph in the profile detail page. This allows you to very quickly see the paths which are causing bottlenecks, for example: