Opening sql queries in new tab is very useful #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only one job has failed in build... |
|
Can anyone merge this PR |
|
@lokeshatbigbasket I hear you. I wonder if it's of any use to make this as an optional setting. However, I am not sure adding that complexity is worth it. |
|
@avelis I felt that when we have list of SQL queries for a request, we might need them to open each query in new tab not in the same tab and going back every time, when handling a larger projects like us, it would add great benefit... |
|
@lokeshatbigbasket I agree on the benefit 👍. I appreciate you making the enhancement to the library! 😀 |
|
@avelis thank you very much... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may want to open the links in sql details page in new tab. Please review and approve this PR.