-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct db in a multi db setup #538
Use correct db in a multi db setup #538
Conversation
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
==========================================
- Coverage 84.60% 84.59% -0.01%
==========================================
Files 51 51
Lines 2059 2058 -1
==========================================
- Hits 1742 1741 -1
Misses 317 317
Continue to review full report at Codecov.
|
SQLCompiler has a .connection instance which is already aware of what database it should use. As such, when running EXPLAIN query let's use that connection instead of connection to a default database. Fixes #522.
@auvipy I think tests should pass now and the PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's see what CI says
Look like coverage has slightly dropped because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to see some more feedback
SQLCompiler has a
.connection
instance which is already aware of whatdatabase it should use. As such, when running EXPLAIN query let's use
that connection instead of connection to a default database.
Fixes #522.
I will add unit tests early next week.