Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for looking up headers on django <3.2 #643

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

albertyw
Copy link
Member

django-silk doesn't support django<3.2 anymore. Therefore, the _get_response_headers function that provides compatibility with django<3.2 isn't needed.

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #643 (f7b35e7) into master (4784e2a) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
+ Coverage   86.40%   86.46%   +0.05%     
==========================================
  Files          52       52              
  Lines        2089     2083       -6     
==========================================
- Hits         1805     1801       -4     
+ Misses        284      282       -2     
Impacted Files Coverage Δ
silk/model_factory.py 84.88% <100.00%> (+0.47%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@albertyw albertyw merged commit 1b23cd8 into jazzband:master Jan 15, 2023
@albertyw albertyw deleted the remove-old-headers branch January 15, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants