New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failures on Windows #707

Merged

50-Course merged 1 commit into jazzband:master from SpecLad:fix-windows-tests

Mar 11, 2024

Contributor

SpecLad commented Mar 5, 2024

_get_prof_file_name did not work correctly when the file separator was not /.


          Fix test failures on Windows

`_get_prof_file_name` did not work correctly when the file separator
was not `/`.

50-Course approved these changes

View reviewed changes

Member

50-Course left a comment

-        filename = file_path.rsplit('/')[-1]
+        filename = os.path.basename(file_path)

LGTM

50-Course merged commit 1cb4623 into jazzband:master

1 check passed

SpecLad deleted the fix-windows-tests branch

March 11, 2024 09:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet