Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional migration tests #92

Merged
merged 2 commits into from
Jan 18, 2016

Conversation

florisdenhengst
Copy link
Contributor

Resolves #91 by running the migration tests from a separate shell script which checks the Django verson before running django-admin.py syncdb or manage.py migrate.

This Resolves jazzband#91.
Django 1.6-1.7 do not have the 'manage.py' interface yet, but rely on 'django-admin.py'.
AFAIK there is no way to add conditional build-steps to a .travis.yml and the recommended way of
making complex build steps is by using a separate shell script.
avelis added a commit that referenced this pull request Jan 18, 2016
@avelis avelis merged commit ee9c989 into jazzband:master Jan 18, 2016
@avelis
Copy link
Collaborator

avelis commented Jan 18, 2016

@florisdenhengst I do apologize for getting to this so late. I appreciate the effort and have merged it in.

@florisdenhengst
Copy link
Contributor Author

Not a problem! Happy to help where possible :)

Would be nice to update some of the old references in packages.json in order to restore references to Travis/CI, but this is only useful when we can create a Travis account for the django-silk.

@avelis
Copy link
Collaborator

avelis commented Jan 18, 2016

@florisdenhengst I agree. I have reached out to @mtford90 on moving the TravisCI account from his personal account into a django-silk account. I might ping him again on Gitter.im about it.

@florisdenhengst
Copy link
Contributor Author

Awesome!

It shouldn't take very long to set it up, so I'm confident it won't be a problem once he's found some time to work on it 😄

@mtford90
Copy link
Collaborator

Thanks guys! I just enabled travis for the django-silk organisation. Should pick up the builds from now.

@avelis
Copy link
Collaborator

avelis commented Jan 19, 2016

@florisdenhengst packages.json has been updated in commit: 02c59d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants