-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecated simple_history_admin_list.display_list()
+ **Release 3.9.0**
#1444
Conversation
This was deprecated in 16b7de7.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1444 +/- ##
==========================================
+ Coverage 96.87% 97.01% +0.14%
==========================================
Files 24 23 -1
Lines 1470 1472 +2
Branches 240 189 -51
==========================================
+ Hits 1424 1428 +4
Misses 25 25
+ Partials 21 19 -2 ☔ View full report in Codecov by Sentry. |
I'm not sure about releasing it as a part of 3.8.1. I'd suggest doing 3.9.0 because it's clearer that something major changed and then we can edit the release notes on GitHub and the changelog to say we messed that up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving the green checkmark to not get in the way, but I'd prefer the 3.9 approach instead.
Sure, it makes sense to bump the minor version when making backward-incompatible changes (like we've done before), even if it was "formally" removed in 3.8.0 🙂 |
simple_history_admin_list.display_list()
+ **Release 3.8.1**simple_history_admin_list.display_list()
+ **Release 3.9.0**
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I wanted to approve this earlier, but I was brewing beer and roasting coffee 😁
Hahah that's alright, hope it turned out well! 😄 For me, this is the last thing I'm doing before going to bed 😁 |
@treyhunner Would you mind releasing 3.9.0 to PyPI? 🙂 We're bumping versions sliightly faster than usual 😅 |
Description
simple_history_admin_list.display_list()
was deprecated in version 3.6.0, or more specifically 16b7de7 - we simply forgot to remove it in #1442 😅Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit run
command to format and lint.AUTHORS.rst
CHANGES.rst