Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated simple_history_admin_list.display_list() + **Release 3.9.0** #1444

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

ddabble
Copy link
Member

@ddabble ddabble commented Jan 24, 2025

Description

simple_history_admin_list.display_list() was deprecated in version 3.6.0, or more specifically 16b7de7 - we simply forgot to remove it in #1442 😅

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added (removed :)) tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@ddabble ddabble added the release Pull requests that prepare for a new release label Jan 24, 2025
@ddabble ddabble requested a review from tim-schilling January 24, 2025 19:10
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.01%. Comparing base (64cdeb4) to head (53e3ee3).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1444      +/-   ##
==========================================
+ Coverage   96.87%   97.01%   +0.14%     
==========================================
  Files          24       23       -1     
  Lines        1470     1472       +2     
  Branches      240      189      -51     
==========================================
+ Hits         1424     1428       +4     
  Misses         25       25              
+ Partials       21       19       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tim-schilling
Copy link
Contributor

I'm not sure about releasing it as a part of 3.8.1. I'd suggest doing 3.9.0 because it's clearer that something major changed and then we can edit the release notes on GitHub and the changelog to say we messed that up.

tim-schilling
tim-schilling previously approved these changes Jan 24, 2025
Copy link
Contributor

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving the green checkmark to not get in the way, but I'd prefer the 3.9 approach instead.

@ddabble
Copy link
Member Author

ddabble commented Jan 26, 2025

Sure, it makes sense to bump the minor version when making backward-incompatible changes (like we've done before), even if it was "formally" removed in 3.8.0 🙂

@ddabble ddabble requested a review from tim-schilling January 26, 2025 14:51
@ddabble ddabble changed the title Remove the deprecated simple_history_admin_list.display_list() + **Release 3.8.1** Remove the deprecated simple_history_admin_list.display_list() + **Release 3.9.0** Jan 26, 2025
Copy link
Contributor

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I wanted to approve this earlier, but I was brewing beer and roasting coffee 😁

@ddabble
Copy link
Member Author

ddabble commented Jan 26, 2025

Hahah that's alright, hope it turned out well! 😄

For me, this is the last thing I'm doing before going to bed 😁

@ddabble ddabble merged commit 55850c2 into jazzband:master Jan 26, 2025
22 checks passed
@ddabble ddabble deleted the remove-3.8-deprecations branch January 26, 2025 23:55
@ddabble
Copy link
Member Author

ddabble commented Jan 27, 2025

@treyhunner Would you mind releasing 3.9.0 to PyPI? 🙂 We're bumping versions sliightly faster than usual 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Pull requests that prepare for a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants