Adds new refresh tokens to OutstandingToken db. #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecarpetjasp
requested review from
Andrew-Chen-Wang,
1ace,
510908220,
2ykwang,
2019342a,
29rou,
1806exe,
0xpranjal,
0xsirsaif,
3ru,
21stPhenom,
0xMRTT,
0xCode7,
0xCR-Tech and
29deepanshutyagi
This was
linked to
issues
Feb 21, 2025
0xCR-Tech
approved these changes
Feb 21, 2025
21stPhenom
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue #363 where new refresh tokens issued out do not get added to the OutstandingToken db.
The issue was resolved by adding a method to the
Tokenclass calledoutstand, which checks if the token is in the outstanding table, and adds it if not.When
ROTATE_REFRESH_TOKENSis set toTrue, theTokenRefreshSerializercalls the.outstand()method on the new refresh token that is issued.All tests ran fine, except for test
test_it_should_blacklist_refresh_token_if_tokens_should_be_rotated_and_blacklisted. The reason for this was it was asserting that outstanding table has1token.However, since this bug is now fixed, there should be in fact
2tokens in the outstanding table. One for the initial refresh token issued during authentication, and the second token which is issued during a refresh, which was implemented in this PR with.outstand(). So I have changed that test to assert two tokens in the table, which is now correct.