Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin pip-tools to pip>=20.0 #1055

Merged
merged 9 commits into from
Mar 3, 2020
Merged

Pin pip-tools to pip>=20.0 #1055

merged 9 commits into from
Mar 3, 2020

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Feb 3, 2020 •
edited
Loading

Refs #926.

Progress

  • remove pip<20.0 compatible code
  • remove obsolete tests
  • remove do_import() from pip_compat module
  • refactor codebase to import objects directly from pip
  • remove pip<20.0 envs from tox.ini
  • remove pip<=20.0 jobs from travis
  • remove pip<=20.0 jobs from appveyor
  • pin pip>=20 in setup.py

Changelog-friendly one-liner: Pin pip-tools to pip>=20.0.

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added this to the 5.0.0 milestone Feb 3, 2020
@atugushev atugushev added backwards incompatible Backwards incompatible change refactor Refactoring code labels Feb 3, 2020
@atugushev atugushev mentioned this pull request Feb 3, 2020
Closed
@codecov
Copy link

codecov bot commented Feb 3, 2020 •
edited
Loading

Codecov Report

Merging #1055 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1055      +/-   ##
==========================================
- Coverage   99.51%   99.41%   -0.10%     
==========================================
  Files          34       34              
  Lines        2478     2411      -67     
  Branches      312      297      -15     
==========================================
- Hits         2466     2397      -69     
- Misses          6        8       +2     
  Partials        6        6
Impacted Files Coverage Δ
piptools/repositories/pypi.py 93.71% <0.00%> (-1.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a58a1c5...2aab742. Read the comment docs.

@atugushev atugushev added the deprecation Related to deprecations or removals label Feb 3, 2020
@atugushev atugushev force-pushed the drop-old-pips branch 3 times, most recently from 4ee72e2 to a9d56f4 Compare February 11, 2020 03:45
@atugushev atugushev changed the title WIP: pin pip-tools to pip>=20.0 Pin pip-tools to pip>=20.0 Feb 11, 2020
@atugushev atugushev marked this pull request as ready for review February 11, 2020 03:56
@atugushev
Drop old pip versions
50ecc4e
@atugushev
Remove old pips from CIs
5f35f82
@atugushev
Remove do_import()
df69144
@atugushev
Remove redundant 20.0 and master CI jobs
6a0a8e5 
Latest pip is 20.0 now, we'll add 20.0 after 20.1 being released.
Remove master, since it's daily run by Github Actions.
@atugushev
Address review comments
2d1cb8c 
- handle ignore_dependencies
- rename `req-tracker` to `resolver`
@atugushev
Fix QA issues
b505af3
@atugushev atugushev requested a review from vphilippon February 28, 2020 14:50
@atugushev
Remove baseline stage from travis
6902e91 
Since there are small numnbers of jobs now, it makes sense
to run all jobs in one stage.
@atugushev
Copy link
Member Author

FTR, rebased onto master and ready to review.

vphilippon
vphilippon approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@vphilippon vphilippon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, beside that, LGTM 👍

Amazing work, thanks a lot!

.travis.yml Show resolved Hide resolved
setup.py Show resolved Hide resolved
@atugushev
Copy link
Member Author

The CI now passes in ~7 minutes 😍 It was 1h 30min before.

@atugushev
Copy link
Member Author

@jazzband/pip-tools Hey, y'all. It seems this PR is ready to merge, thus I'm going to do it tomorrow if nobody minds. This means we'll bump version to 5.0.0 before pip==20.1 is being released.

@vphilippon @auvipy thank you so much for reviewing this! Much appreciated 🙏

@atugushev atugushev merged commit 888c2a1 into jazzband:master Mar 3, 2020
@codingjoe
Copy link
Member

🥇 🎉

@atugushev atugushev mentioned this pull request Mar 22, 2020
Merged
@atugushev atugushev deleted the drop-old-pips branch March 22, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

@vphilippon vphilippon vphilippon approved these changes

Assignees
No one assigned
Labels
backwards incompatible Backwards incompatible change deprecation Related to deprecations or removals refactor Refactoring code
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@atugushev @codingjoe @vphilippon @auvipy