Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip line number annotations #1075

Conversation

adamchainz
Copy link
Contributor

@adamchainz adamchainz commented Feb 25, 2020

Fixes #1074.

Changelog-friendly one-liner: Strip line number annotations such as "(line 12)" from file requirements, to prevent diff noise when modifying input requirement files.

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@adamchainz adamchainz force-pushed the issue_1074_strip_trailing_line_annotations branch from e71b237 to e9386de Compare February 25, 2020 22:57
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #1075 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1075   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          34       34           
  Lines        2476     2478    +2     
  Branches      312      312           
=======================================
+ Hits         2464     2466    +2     
  Misses          6        6           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a288f3...e9386de. Read the comment docs.

@adamchainz adamchainz changed the title Strip line annotations Strip line number annotations Feb 26, 2020
@atugushev atugushev added this to the 4.5.1 milestone Feb 26, 2020
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Looks good. Sorry for the inconvenience :(

@adamchainz
Copy link
Contributor Author

Not a problem, thanks for the maintenance!

@atugushev atugushev merged commit 66d63f4 into jazzband:master Feb 26, 2020
@atugushev
Copy link
Member

pip-tools v4.5.1 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "(line X)" annotations from output
4 participants