-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn when --generate-hashes output is uninstallable #814
Conversation
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
==========================================
+ Coverage 98.83% 98.84% +0.01%
==========================================
Files 36 36
Lines 2153 2172 +19
Branches 276 279 +3
==========================================
+ Hits 2128 2147 +19
Misses 15 15
Partials 10 10
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
=========================================
- Coverage 98.83% 98.8% -0.04%
=========================================
Files 36 36
Lines 2153 2177 +24
Branches 276 279 +3
=========================================
+ Hits 2128 2151 +23
Misses 15 15
- Partials 10 11 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
==========================================
+ Coverage 98.83% 98.84% +0.01%
==========================================
Files 36 36
Lines 2153 2172 +19
Branches 276 279 +3
==========================================
+ Hits 2128 2147 +19
Misses 15 15
Partials 10 10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…nd/pip-tools#814) to ensure the generated requirements.txt can be installed using pip.
pip-compile --generate-hashes
can generate arequirements.txt
file that will be rejected bypip install
, in at least two ways:(1) When unsafe packages are left out (#806):
(2) When unhashable URL requirements are included:
This PR prints warning messages in the generated requirements.txt file for both of those situations, and also prints a warning message to stderr at the end:
Note that the warning message text is static; this doesn't attempt to suggest a fixed URL for Github or similar VCS URLs, though that would be possible as an enhancement.
Here's an image of the output with color:
Tests are included for the two warning situations.
Changelog-friendly one-liner: Warn when pip-compile --generate-hashes output is uninstallable
Contributor checklist