-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: "zero" install now lives up to its name #1219
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1219 +/- ##
=========================================
Coverage 58.82% 58.82%
Complexity 1057 1057
=========================================
Files 86 86
Lines 5661 5661
Branches 954 954
=========================================
Hits 3330 3330
Misses 1839 1839
Partials 492 492
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
WDYT about this @maxandersen . I feel this is a better way of handling the "zero install" issue. So in this new version the startup scripts only run if they find a local Edit: the cleanup will not touch |
so just thinking it through - it makes sense; but side-effect is that doing curl-jbang twice now will "cost" more than before, right? not necessarily bad - but if the case it gets connected to how we currently recommend installing quarkus cli where we call curl twice - one for setup trust, other for a run...which is verbose but fast. thus related to trust workflow. |
It's indeed slightly slower to do two curls now, but Jbang isn't that big luckily. |
We're not doing a "hidden install" anymore, but (inefficiently) downloading Jbang to a temporary location and cleaning it up after each invocation. Fixes jbangdev#1218
dcb1c04
to
aa93695
Compare
lets not merge this before we still have a working one-liner "app install" option that works, i.e.:
|
Turns out that this worked all along, the But while testing this I needed a clean environment so I started a container and realized that in those kind of situations it won't work anyway because a) we're redirecting stdin and b) there's no way to show a GUI popup. And then I thought: what if we read directly from Therefore I created this PR: #1312 . We can merge this PR when that one is merged. |
merging this so can do a release with this in effect and test over the weekend :) |
This reverts commit ea20eff.
had to revert this as "curl -Ls https://sh.jbang.dev | bash -s - app install --fresh --force quarkus@quarkusio" stopped working. |
We're not doing a "hidden install" anymore, but (inefficiently)
downloading Jbang to a temporary location and cleaning it up after
each invocation.
Fixes #1218