-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable jbang [email protected] and jbang tree@https:/jbang.dev #1274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8c959d7
to
cb4c50c
Compare
Codecov Report
@@ Coverage Diff @@
## main #1274 +/- ##
============================================
+ Coverage 58.75% 59.09% +0.33%
- Complexity 1126 1151 +25
============================================
Files 96 97 +1
Lines 5962 6016 +54
Branches 991 998 +7
============================================
+ Hits 3503 3555 +52
+ Misses 1955 1952 -3
- Partials 504 509 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cb4c50c
to
9d2ce04
Compare
some times creating a root jbang-catalog repo can be problematic or the base github user/org is not really related so instead of
jbang cli@awesomefwk
it becomesjbang cli@l33t1974/awesomefwk
For a while I had the idea jbang alias should support allowing
jbang [email protected]
whereawesome.fwk
is treated as https://awesome.fwk instead of looked up in github/gitlab names.It is only a draft for now but if you build this (with -x test as the test is broken for now) you can do:
jbang [email protected]
because I created https://jbang.dev/jbang-catalog.jsonsimilar
jbang [email protected]
works.imagine,
jbang [email protected]
as opposed tojbang quarkus@RedHatOfficial
- as an example.wdyt ?
btw. this also enables
jbang yourscript@https://whatever.path/sdf/sf/jbang-catalog.json
- not pretty but there for completenes.even yourscript@file:///path/on/idsk should work but something goes wrong with relative resolve.