Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI for 3rd party integration into build - enabling Quarkus native apps and use of Quarkus programming model #261

Closed
wants to merge 1 commit into from
+0 −22
Closed

SPI for 3rd party integration into build - enabling Quarkus native apps and use of Quarkus programming model #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/main/java/dev/jbang/ArtifactInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import java.util.Objects;

import org.jboss.shrinkwrap.resolver.api.maven.coordinate.MavenCoordinate;
import org.jboss.shrinkwrap.resolver.api.maven.coordinate.MavenCoordinates;

/**
* class describing artifact coordinates and its resolved physical location.
Expand Down Expand Up @@ -32,15 +31,6 @@ public String toString() {
return getCoordinate().toCanonicalForm() + "=" + path;
}

static public ArtifactInfo fromExternalString(String externalString) {

MavenCoordinate coordinate = MavenCoordinates.createCoordinate(
externalString.substring(0, externalString.indexOf("=")));
File file = new File(externalString.substring(externalString.indexOf("=") + 1, externalString.length()));

return new ArtifactInfo(coordinate, file);
}

@Override
public boolean equals(Object o) {
if (this == o)
Expand Down
12 changes: 0 additions & 12 deletions src/test/java/dev/jbang/TestArtifactInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,6 @@

public class TestArtifactInfo {

@Test
public void testArtifactFromExternalString() {

ArtifactInfo info = ArtifactInfo.fromExternalString("g:a:23.4=/here/is/a/path");

assertThat(info.asFile().getPath(), equalTo("/here/is/a/path"));
assertThat(info.getCoordinate().getGroupId(), equalTo("g"));
assertThat(info.getCoordinate().getArtifactId(), equalTo("a"));
assertThat(info.getCoordinate().getVersion(), equalTo("23.4"));

}

@Test
public void testDependencyCache() {

Expand Down