Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance scp.py for scp folder #187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liliangnike
Copy link

Enhance scp.py to make the bahaviors to be identical to native scp command behaviors:

  1. When meets non-regular files, scp.py should prompt.
  2. After prompt, scp.py should continue to copy other remaining non-regular files.

Enhance scp.py to make the bahaviors to be identical to native scp command behaviors:
1. When meets non-regular files, scp.py should prompt.
2. After prompt, scp.py should continue to copy other remaining non-regular files.
@remram44
Copy link
Collaborator

Please stop sending PRs over and over. You can update an existing one.

@liliangnike
Copy link
Author

Ok. Thanks. But really sorry about that.

@liliangnike
Copy link
Author

Any comment on code change? Thanks!

@remram44
Copy link
Collaborator

remram44 commented Dec 5, 2023

I'm worried that this will ignore too many errors, not just the "non-regular file" errors. At the minimum this should be configurable, and it would be great to have tests.

@liliangnike
Copy link
Author

When copying directories, native scp command ignores all the non-regular file errors. But there is error log on this. The key point is that native scp command can continue to copy all the regular files in the remaining files under this folder.

For recursive case, what are the other error code values (normally, they are C, T, D and E) when non-regular files are met?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants