Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gpt 2 sweep #140

Merged
merged 4 commits into from
May 12, 2024
Merged

Gpt 2 sweep #140

merged 4 commits into from
May 12, 2024

Conversation

tomMcGrath
Copy link
Contributor

Description

Adds base sweep settings for gpt-2-small. Sweeps are intentionally relatively short: most of the action that tells us whether a sweep will be obviously bad seems to happen relatively quickly. Based on Anthropic SAE replication.

W&B dashboard for this run.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

You have tested formatting, typing and unit tests (acceptance tests not currently in use)

  • I have run make check-ci to check format and linting. (you can run make format to format code if needed.)

Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.21%. Comparing base (bdef2cf) to head (af93303).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   72.21%   72.21%           
=======================================
  Files          17       17           
  Lines        1814     1814           
  Branches      295      295           
=======================================
  Hits         1310     1310           
  Misses        432      432           
  Partials       72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hijohnnylin
Copy link
Collaborator

looks good! maybe i should make this the default for the ansible example run? (@jbloomAus)

also was 200_00 intentional for training steps?

total_training_steps = 200_00

@tomMcGrath
Copy link
Contributor Author

tomMcGrath commented May 12, 2024 via email

@jbloomAus
Copy link
Owner

@tomMcGrath will know better if this is a reasonable example run. My guess is not because of we run this a lot paralleling by a large number will use more compute.

@jbloomAus jbloomAus merged commit 4cb270b into jbloomAus:main May 12, 2024
7 checks passed
tom-pollak pushed a commit to tom-pollak/SAELens that referenced this pull request Oct 22, 2024
* sweep settings for gpt2-small

* get model string right

* fix some comments that don't apply now

* formatting fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants