-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with resumption testing #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
- Coverage 72.21% 72.20% -0.02%
==========================================
Files 17 17
Lines 1814 1813 -1
Branches 295 295
==========================================
- Hits 1310 1309 -1
Misses 432 432
Partials 72 72 ☔ View full report in Codecov by Sentry. |
thanks for catching this! really appreciate it! |
jbloomAus
pushed a commit
that referenced
this pull request
May 15, 2024
* Adds state_dict to L1Scheduler * investigating test failure * fix: Fix issues with resumption testing (#144) * fix always-true comparison in train context testing * set default warmup steps to zero * remove unused type attribute from L1Scheduler * update training tests to use real context builder * add docstring for build_train_ctx * 2.1.2 Automatically generated by python-semantic-release * Adds state_dict to L1Scheduler * investigating test failure --------- Co-authored-by: github-actions <[email protected]>
tom-pollak
pushed a commit
to tom-pollak/SAELens
that referenced
this pull request
Oct 22, 2024
* fix always-true comparison in train context testing * set default warmup steps to zero * remove unused type attribute from L1Scheduler * update training tests to use real context builder * add docstring for build_train_ctx
tom-pollak
pushed a commit
to tom-pollak/SAELens
that referenced
this pull request
Oct 22, 2024
…oomAus#143) * Adds state_dict to L1Scheduler * investigating test failure * fix: Fix issues with resumption testing (jbloomAus#144) * fix always-true comparison in train context testing * set default warmup steps to zero * remove unused type attribute from L1Scheduler * update training tests to use real context builder * add docstring for build_train_ctx * 2.1.2 Automatically generated by python-semantic-release * Adds state_dict to L1Scheduler * investigating test failure --------- Co-authored-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test
test_save_load_and_resume_checkpoint
was erroneously passing because of an incorrect comparion. Fixing this comparison exposed a further error in the test: the train context defined bybuild_train_ctx
defined in the test file didn't conform to the behaviour of_build_train_context
and was generating incorrect results which caused the fixed test to fail.This PR fixes the incorrect comparison, changes the testing train context builder to use the real context builder plus some minor overrides to enable testing, and removes an unused attribute from L1Scheduler that was causing comparisons to fail.
Type of change
Please delete options that are not relevant.
Checklist:
You have tested formatting, typing and unit tests (acceptance tests not currently in use)
make check-ci
to check format and linting. (you can runmake format
to format code if needed.)