Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hook z training reshape bug #165

Merged
merged 2 commits into from
May 29, 2024
Merged

Fix hook z training reshape bug #165

merged 2 commits into from
May 29, 2024

Conversation

jbloomAus
Copy link
Owner

Description

Temporary solution to hook z reshaping bug in training described in #164. Checks if the sae is doing reshaping and if so turns it off during evals where we want to do reshaping ourselves. This is more a quick fix than an ideal long term solution as we should likely remove reshaping responsibilities from the SAE and make the caller provide the correct shaped object.

Fixes #164

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

You have tested formatting, typing and unit tests (acceptance tests not currently in use)

  • I have run make check-ci to check format and linting. (you can run make format to format code if needed.)

@jbloomAus jbloomAus merged commit 0550ae3 into main May 29, 2024
4 checks passed
tom-pollak pushed a commit to tom-pollak/SAELens that referenced this pull request Oct 22, 2024
* remove file duplicate

* fix: hook-z evals working, and reshaping mode more explicit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Cannot train on z: interfaces disagree on shape?
1 participant